[android] Fix some parts of Bundle in Android. #2120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
The library/executable naming is not part of the FHS, its part of the Unix heritage. |
Member
|
@swift-ci please test |
millenomi
reviewed
Apr 15, 2019
While Android does not follow FHS, and it doesn't seem to have something similar published, it follows some conventions of Unix. One of them is that libraries are normally named prefixed with "lib" and suffixed with ".so" like Linux. Executables are also normally named without any prefix nor suffix. The changes in this commit lift up restrictions that were in place for Android, and allow some of the Bundle tests to pass on Android (and lift another restriction in TestObjCRuntime). While bundles might never be a common construct in Android, these changes at least allow to test some of the scenarios, in case someone needs this behaviour.
drodriguez
force-pushed
the
android-bundle-executable
branch
from
3642004 to
fdddfbe
Compare
Contributor
Author
|
Incorporated the feedback from Lily and reworded the commit/PR message to not imply that libraries or executable naming are related to FHS (from the comments in the code I thought they were). |
Contributor
|
@swift-ci test |
Member
|
@swift-ci please test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While Android does not follow FHS, and it doesn't seem to have something
similar published, it follows some conventions of Unix. One of them
is that libraries are normally named prefixed with "lib" and suffixed
with ".so" like Linux. Executables are also normally named without any
prefix nor suffix.
The changes in this commit lift up restrictions that were in place for
Android, and allow some of the Bundle tests to pass on Android (and lift
another restriction in TestObjCRuntime).
While bundles might never be a common construct in Android, these
changes at least allow to test some of the scenarios, in case someone
needs this behaviour.
This allows
TestBundle,TestNSError,TestPropertyListSerialization,TestObjCRuntime, andTestNSKeyedUnarchiverto pass on Android devices.